feat: Add AWS Web Idenity compability to PROPAGATE_AWS_AUTH_TOKENS #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds compatibilty with AWS authentication using delegated authentication using web identity token files (useful with AWS EKS for example). It adds an environment variable and a volume if the AWS_WEB_IDENTITY_TOKEN_FILE is present to be able to use them from the specified container. In addition, we have added the AWS_STS_REGION_ENDPOINTS variable compatibility which allows you AWS IAM calls to be directed towards the region you are in instead of redirecting automatically to us-east-1 by default.
toote
approved these changes
May 30, 2023
|
Thanks a lot for the contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds compatibilty with AWS authentication using delegated authentication using web identity token files (useful with AWS EKS for example). It adds an environment variable and a volume if the AWS_WEB_IDENTITY_TOKEN_FILE is present to be able to use them from the specified container.
In addition, we have added the AWS_STS_REGION_ENDPOINTS variable compatibility which allows you AWS IAM calls to be directed towards the region you are in instead of redirecting automatically to us-east-1 by default.
If you need more explanation or have concerns with the code, I'll be happy to address and/or correct them if needed :)