Skip to content

Bash <4.2 compatibility #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Bash <4.2 compatibility #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5db63ff
Avoid using -v for bash versions older than 4.2
toote Mar 9, 2023
9731572
Correct shellcheck warning
toote Mar 9, 2023
681132c
Update version numbers in readme for next release
toote Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ steps:
- command: "go build -o dist/my-app ."
artifact_paths: "./dist/my-app"
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "golang:1.11"
```

Expand All @@ -23,7 +23,7 @@ Windows images are also supported:
steps:
- command: "dotnet publish -c Release -o published"
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "microsoft/dotnet:latest"
always-pull: true
```
Expand All @@ -35,7 +35,7 @@ If you want to control how your command is passed to the docker container, you c
```yml
steps:
- plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "mesosphere/aws-cli"
always-pull: true
command: ["s3", "sync", "s3://my-bucket/dist/", "/app/dist"]
Expand All @@ -50,7 +50,7 @@ Note: If you are utilizing Buildkite's [Elastic CI Stack S3 Secrets plugin](http
steps:
- command: "yarn install; yarn run test"
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "node:7"
always-pull: true
environment:
Expand All @@ -68,7 +68,7 @@ steps:
env:
MY_SPECIAL_BUT_PUBLIC_VALUE: kittens
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "node:7"
always-pull: true
propagate-environment: true
Expand All @@ -82,7 +82,7 @@ steps:
env:
MY_SPECIAL_BUT_PUBLIC_VALUE: kittens
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "node:7"
always-pull: true
propagate-aws-auth-tokens: true
Expand All @@ -94,7 +94,7 @@ You can pass in additional volumes to be mounted. This is useful for running Doc
steps:
- command: "docker build . -t image:tag; docker push image:tag"
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "docker:latest"
always-pull: true
volumes:
Expand All @@ -107,7 +107,7 @@ You can disable the default behaviour of mounting in the checkout to `workdir`:
steps:
- command: "npm start"
plugins:
- docker#v5.4.0:
- docker#v5.5.1:
image: "node:7"
always-pull: true
mount-checkout: false
Expand Down
4 changes: 2 additions & 2 deletions hooks/command
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,8 +450,8 @@ if [[ -n "${BUILDKITE_PLUGIN_DOCKER_MEMORY_SWAPPINESS:-}" ]]; then
args+=("--memory-swappiness=${BUILDKITE_PLUGIN_DOCKER_MEMORY_SWAPPINESS}")
fi

# Handle entrypoint if set (or empty), and default shell to disabled
if [[ -v BUILDKITE_PLUGIN_DOCKER_ENTRYPOINT ]] ; then
# Handle entrypoint if set, and default shell to disabled
if [[ -n ${BUILDKITE_PLUGIN_DOCKER_ENTRYPOINT+x} ]]; then
args+=("--entrypoint" "${BUILDKITE_PLUGIN_DOCKER_ENTRYPOINT}")
shell_disabled=1
fi
Expand Down