Skip to content

Fix incorrect comments in FloatRules, AnyRules, and TimestampRules #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikrsna-buf merged 2 commits into from
Mar 5, 2026
Merged

Fix incorrect comments in FloatRules, AnyRules, and TimestampRules #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d507ce
Fix inconsistency in comments
srikrsna-buf Feb 28, 2026
725300d
gen
srikrsna-buf Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions proto/protovalidate/buf/validate/validate.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ message FloatRules {
expression: "!(this in getField(rules, 'in')) ? 'must be in list %s'.format([getField(rules, 'in')]) : ''"
}];

// `in` requires the field value to not be equal to any of the specified
// `not_in` requires the field value to not be equal to any of the specified
// values. If the field value is one of the specified values, an error
// message is generated.
//
Expand Down Expand Up @@ -4436,7 +4436,7 @@ message AnyRules {
// ```
repeated string in = 2;

// requires the field's type_url to be not equal to any of the specified values. If it matches any of the specified values, an error message is generated.
// `not_in` requires the field's type_url to be not equal to any of the specified values. If it matches any of the specified values, an error message is generated.
//
// ```proto
// message MyAny {
Expand Down Expand Up @@ -4753,12 +4753,12 @@ message TimestampRules {
expression: "this != getField(rules, 'const') ? 'must equal %s'.format([getField(rules, 'const')]) : ''"
}];
oneof less_than {
// requires the duration field value to be less than the specified value (field < value). If the field value doesn't meet the required conditions, an error message is generated.
// `lt` requires the timestamp field value to be less than the specified value (field < value). If the field value doesn't meet the required conditions, an error message is generated.
//
// ```proto
// message MyDuration {
// // duration must be less than 'P3D' [duration.lt]
// google.protobuf.Duration value = 1 [(buf.validate.field).duration.lt = { seconds: 259200 }];
// message MyTimestamp {
// // timestamp must be less than '2023-01-01T00:00:00Z' [timestamp.lt]
// google.protobuf.Timestamp value = 1 [(buf.validate.field).timestamp.lt = { seconds: 1672444800 }];
// }
// ```
google.protobuf.Timestamp lt = 3 [(predefined).cel = {
Expand All @@ -4768,7 +4768,7 @@ message TimestampRules {
"? 'must be less than %s'.format([rules.lt]) : ''"
}];

// requires the timestamp field value to be less than or equal to the specified value (field <= value). If the field value doesn't meet the required conditions, an error message is generated.
// `lte` requires the timestamp field value to be less than or equal to the specified value (field <= value). If the field value doesn't meet the required conditions, an error message is generated.
//
// ```proto
// message MyTimestamp {
Expand Down
14 changes: 7 additions & 7 deletions tools/internal/gen/buf/validate/validate.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading