Update protovalidate #293
Merged
Update protovalidate #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sri Krishna <[email protected]>
|
The latest Buf updates on your PR. Results from workflow Buf / validate-protos (pull_request).
|
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
srikrsna-buf
commented
Dec 9, 2025
Comment on lines
-126
to
-132
| out[i].Env, err = out[i].Env.Extend( | ||
| cel.Constant( | ||
| "rule", | ||
| pvcel.ProtoFieldToType(ruleDescriptor, true, false), | ||
| pvcel.ProtoFieldToValue(ruleDescriptor, ruleValue, false), | ||
| ), | ||
| ) |
Member
Author
There was a problem hiding this comment.
This never worked for message fields. The ProtoFieldToValue is using the default adapter of cel-go that doesn't handle protobuf messages except for wrappers. This always returned an error value.
Because we try to reduce the AST ahead of time and the rule variable was always being optimized away, we never hit a problem.
hudlow
approved these changes
Dec 9, 2025
Signed-off-by: Sri Krishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.