V2: Change default value of plugin option import_extension to none#832
Merged
srikrsna-buf merged 4 commits intov2from May 9, 2024
Merged
V2: Change default value of plugin option import_extension to none#832srikrsna-buf merged 4 commits intov2from
import_extension to none#832srikrsna-buf merged 4 commits intov2from
Conversation
timostamm
reviewed
May 9, 2024
Member
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
Looks good to me, but can you update packages/protoc-gen-es/README.md ?
| let keepEmptyFiles = false; | ||
| const rewriteImports: RewriteImports = []; | ||
| let importExtension = ".js"; | ||
| let importExtension = ""; |
timostamm
changed the title
import_extension to noneimport_extension to none
timostamm
reviewed
May 9, 2024
srikrsna-buf
force-pushed
the
sk/import_extension
branch
from
3956a3c to
0d0afc0
Compare
timostamm
approved these changes
May 9, 2024
timostamm
changed the title
import_extension to noneimport_extension to none
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change default value of
import_extensiontononefrom.js.In v1, we generate code using
.jsextension which is the spec compliant way (and has been for sometime) of importing js files. Node, TS, and browsers support this but bundlers still haven't caught up with it. Users filed several issues related to this.With this change, the default will work in most places and where users do need them it can be configured using the
import_extension=.jsplugin option.Important
This change affects all plugins written using protoplugin when they upgrade to v2.