Merged
Conversation
timostamm
commented
Apr 22, 2024
Comment on lines
+34
to
+37
| "files": [ | ||
| "dist/**", | ||
| "bin/**" | ||
| ] |
Member
Author
There was a problem hiding this comment.
We don't need to ship our tsconfig.json and src. The result:
$ npm pack -w packages/protoc-gen-es
npm notice
npm notice 📦 @bufbuild/[email protected]
npm notice === Tarball Contents ===
npm notice 5.0kB README.md
npm notice 174B bin/protoc-gen-es
npm notice 1.0kB dist/cjs/package.json
npm notice 14.5kB dist/cjs/src/protoc-gen-es-plugin.js
npm notice 5.5kB dist/cjs/src/util.js
npm notice 903B package.json
...
smaye81
approved these changes
Apr 22, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active support for Node.js v10 ended nearly four years ago, security support ended nearly three years ago. I think we can safely remove the fallback for subpath exports in v2.
For context, see #802.
We still maintain the package.json field
typesVersionsso that TypeScript can see types with Node10 module resolution (it's still commonly used with the aliasnode). But there doesn't appear to be an obvious reason to maintain JS files for runtime purposes.