Respect json_name in messages created from a descriptor set#171
Merged
timostamm merged 2 commits intoJul 27, 2022
Merged
Conversation
We have a feature that allows creating a message type at run time from a set of file descriptors. This feature has a bug - it does not respect the json_name field option. This adds test coverage for this situation, and fixes the issue.
paul-sachs
approved these changes
Jul 27, 2022
doriable
approved these changes
Jul 27, 2022
timostamm
deleted the
tstamm/respect-json-name-in-message-types-from-descriptors
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a feature that allows creating a message type at run time from a set of file descriptors. This feature has a bug - it does not respect the json_name field option.
This adds test coverage for this situation, and fixes the issue.