Clarify what the time values mean#1135
Closed
Happypig375 wants to merge 11 commits intobryanedds:masterfrom
Closed
Clarify what the time values mean#1135Happypig375 wants to merge 11 commits intobryanedds:masterfrom
Happypig375 wants to merge 11 commits intobryanedds:masterfrom
Conversation
Owner
|
Maybe better than -
would be -
|
Collaborator
Author
|
Updated the words used |
Collaborator
Author
|
Ok done |
Owner
|
None of those commas are grammatically correct :D Also 'reality time span' is quite awkward phrasing. I might just do the changes on my end since I'm a native English speaker :) |
Collaborator
Author
|
Sure |
bryanedds
added a commit
that referenced
this pull request
Sep 9, 2025
Owner
|
Did my own version of this - 41cbea5 |
Collaborator
Author
|
@bryanedds The original intention of this PR is to clarify that clock time is in seconds, that commit didn't do that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.