Skip to content

chore: make openTelemetryClient more abstract #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bruuuuuuuce merged 4 commits into from
May 6, 2024
Merged

chore: make openTelemetryClient more abstract #24

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12a91cf
chore: make openTelemetryClient more abstract
rishtigupta May 6, 2024
e41f18f
chore: make headers as one param
rishtigupta May 6, 2024
3d1eb77
fix: make headers of type Header[]
rishtigupta May 6, 2024
1f70bf4
fix: lint issue
rishtigupta May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/goodmetrics/metricsSetups.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ interface ConfigureBatchedPreaggregatedLightstepSinkProps {
}

interface PrivateOtelClientProps {
lightstepToken: string;
lightstepUrl: string;
lightstepPort: number;
headers: Header[];
ingestUrl: string;
ingestPort: number;
metricDimensions: Map<string, Dimension>;
resourceDimensions: Map<string, Dimension>;
}
Expand Down Expand Up @@ -125,9 +125,11 @@ export class MetricsSetups {
metricDimensions: props.metricDimensions ?? new Map<string, Dimension>(),
resourceDimensions:
props.resourceDimensions ?? new Map<string, Dimension>(),
lightstepToken: props.lightstepAccessToken,
lightstepPort: props.lightstepPort ?? 443,
lightstepUrl: props.lightstepUrl ?? 'ingest.lightstep.com',
ingestPort: props.lightstepPort ?? 443,
ingestUrl: props.lightstepUrl ?? 'ingest.lightstep.com',
headers: [
new Header('lightstep-access-token', props.lightstepAccessToken),
],
});

const unarySink = this.configureBatchedUnaryLightstepSink({
Expand Down Expand Up @@ -267,15 +269,13 @@ export class MetricsSetups {
return sink;
}

private static opentelemetryClient(
static opentelemetryClient(
props: PrivateOtelClientProps
): OpenTelemetryClient {
const headers = [
new Header('lightstep-access-token', props.lightstepToken),
];
const headers = props.headers;
return OpenTelemetryClient.connect({
sillyOtlpHostname: props.lightstepUrl ?? 'ingest.lightstep.com',
port: props.lightstepPort ?? 443,
sillyOtlpHostname: props.ingestUrl,
port: props.ingestPort,
metricDimensions: props.metricDimensions ?? new Map<string, Dimension>(),
resourceDimensions:
props.resourceDimensions ?? new Map<string, Dimension>(),
Expand Down