Skip to content

Comments

mixpanel api secret support#1723

Merged
mustafa3rsan merged 1 commit intomainfrom
mixpanel-api-secet
Feb 23, 2026
Merged

mixpanel api secret support#1723
mustafa3rsan merged 1 commit intomainfrom
mixpanel-api-secet

Conversation

@mustafa3rsan
Copy link
Contributor

No description provided.

…and updating related schemas and configurations.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Comment on lines 20 to 23
params.Set("username", c.Username)
params.Set("password", c.Password)
params.Set("api_secret", c.APISecret)
params.Set("project_id", c.ProjectID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty values set unconditionally in URI parameters. Conditionally add only non-empty values (see pkg/socrata/config.go:15-23, pkg/shopify/config.go:18-23).

Suggested change
params.Set("username", c.Username)
params.Set("password", c.Password)
params.Set("api_secret", c.APISecret)
params.Set("project_id", c.ProjectID)
if c.Username != "" {
params.Set("username", c.Username)
}
if c.Password != "" {
params.Set("password", c.Password)
}
if c.APISecret != "" {
params.Set("api_secret", c.APISecret)
}
if c.ProjectID != "" {
params.Set("project_id", c.ProjectID)
}
Prompt To Fix With AI
This is a comment left during a code review.
Path: pkg/mixpanel/config.go
Line: 20-23

Comment:
Empty values set unconditionally in URI parameters. Conditionally add only non-empty values (see `pkg/socrata/config.go:15-23`, `pkg/shopify/config.go:18-23`).

```suggestion
	if c.Username != "" {
		params.Set("username", c.Username)
	}
	if c.Password != "" {
		params.Set("password", c.Password)
	}
	if c.APISecret != "" {
		params.Set("api_secret", c.APISecret)
	}
	if c.ProjectID != "" {
		params.Set("project_id", c.ProjectID)
	}
```

How can I resolve this? If you propose a fix, please make it concise.

@mustafa3rsan mustafa3rsan merged commit f0a2f20 into main Feb 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants