Scd2 incremental key column

[sabrikaragonen]

Enable using a specified column via incremental_key for _valid_from and _valid_until fields in scd2_by_column materialization.

---

Slack Thread

  

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[greptile-apps]

_{28 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

The quoted column name should be prefixed with the table alias for clarity

Suggested change

	validFromExpr = QuoteIdentifier(asset.Materialization.IncrementalKey)
	validFromExpr = "src." + QuoteIdentifier(asset.Materialization.IncrementalKey)

_{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix With AI

This is a comment left during a code review.
Path: pkg/postgres/materialization.go
Line: 332

Comment:
The quoted column name should be prefixed with the table alias for clarity

```suggestion
		validFromExpr = "src." + QuoteIdentifier(asset.Materialization.IncrementalKey)
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Missing table alias prefix and type casting

Suggested change

	validFromExpr = asset.Materialization.IncrementalKey
	validFromExpr = fmt.Sprintf("CAST(src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)

Prompt To Fix With AI

This is a comment left during a code review.
Path: pkg/databricks/materialization.go
Line: 238

Comment:
Missing table alias prefix and type casting

```suggestion
		validFromExpr = fmt.Sprintf("CAST(src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Missing src. table alias prefix - column reference will fail

Suggested change

	validFromExpr = fmt.Sprintf("CAST (%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)
	validFromExpr = fmt.Sprintf("CAST (src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)

Prompt To Fix With AI

This is a comment left during a code review.
Path: pkg/bigquery/materialization.go
Line: 523

Comment:
Missing `src.` table alias prefix - column reference will fail

```suggestion
		validFromExpr = fmt.Sprintf("CAST (src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Missing src. table alias prefix - column reference will fail

Suggested change

	validFromExpr = fmt.Sprintf("CAST(%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)
	validFromExpr = fmt.Sprintf("CAST(src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)

Prompt To Fix With AI

This is a comment left during a code review.
Path: pkg/snowflake/materialization.go
Line: 395

Comment:
Missing `src.` table alias prefix - column reference will fail

```suggestion
		validFromExpr = fmt.Sprintf("CAST(src.%s AS TIMESTAMP)", asset.Materialization.IncrementalKey)
```

How can I resolve this? If you propose a fix, please make it concise.