Reduce allocations on update #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was planning to do something similar, but since this PR hasn’t been merged yet, there’s no point in duplicating the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed unnecessary allocations in the render_script and camera module update functions. I've also re-ordered a couple of things and added a few locals for readability and convenience.
In camera's update this results in a ~22% reduction. Unfortunately, the garbage produced by the many calls to
go.getis quite significant, ~5000B, so the reduction of vmath garbage by ~1500B doesn't look so great in comparison.The code is arguably a bit less readable and elegant; feel free to reject some or all of these changes.