Use slice::chunks on Windows #856
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
force-pushed
the
windows
branch
2 times, most recently
from
7ebe027 to
a7e4b58
Compare
Owner
|
I don't have time to consider this now. Thanks though! |
Contributor
Author
That fine! This is just one of many changes from |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do the same overflow check but in a much more readable/efficient way. This also helps toward overall simplification of
rand.rsand the eventual elimination ofmod sysrand_chunk(see followup).Also removes
polyfill::usize_from_u32as we already check compatiblity in theassert!()(so we know theascast is safe). We should probably cleanuppolyfillanyway, as most of the proposed features have gone in a different direction or are unlikely to ever be stabilized.