Skip to content

Fix: clang-cl based Windows AArch64 builds #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: clang-cl based Windows AArch64 builds #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b39341
build.rs: Fix Windows AArch64 (cross-)builds done with clang-cl
dragonmux Oct 14, 2025
ad723c6
build.rs: Turn off some nuisance warnings from `/Wall` meaning `-Weve…
dragonmux Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 45 additions & 19 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,23 +182,46 @@ fn cpp_flags(compiler: &cc::Tool) -> &'static [&'static str] {
];
NON_MSVC_FLAGS
} else {
static MSVC_FLAGS: &[&str] = &[
"/Gy", // Enable function-level linking.
"/Zc:wchar_t",
"/Zc:forScope",
"/Zc:inline",
// Warnings.
"/Wall",
"/wd4127", // C4127: conditional expression is constant
"/wd4464", // C4464: relative include path contains '..'
"/wd4514", // C4514: <name>: unreferenced inline function has be
"/wd4710", // C4710: function not inlined
"/wd4711", // C4711: function 'function' selected for inline expansion
"/wd4820", // C4820: <struct>: <n> bytes padding added after <name>
"/wd5045", /* C5045: Compiler will insert Spectre mitigation for memory load if
* /Qspectre switch specified */
];
MSVC_FLAGS
if !compiler.is_like_clang_cl() {
static MSVC_FLAGS: &[&str] = &[
"/Gy", // Enable function-level linking.
"/Zc:wchar_t",
"/Zc:forScope",
"/Zc:inline",
// Warnings.
"/Wall",
"/wd4127", // C4127: conditional expression is constant
"/wd4464", // C4464: relative include path contains '..'
"/wd4514", // C4514: <name>: unreferenced inline function has be
"/wd4710", // C4710: function not inlined
"/wd4711", // C4711: function 'function' selected for inline expansion
"/wd4820", // C4820: <struct>: <n> bytes padding added after <name>
"/wd5045", /* C5045: Compiler will insert Spectre mitigation for memory load if
* /Qspectre switch specified */
];
MSVC_FLAGS
} else {
static CLANG_CL_FLAGS: &[&str] = &[
"/Gy", // Enable function-level linking.
"/Zc:wchar_t",
"/Zc:forScope",
"/Zc:inline",
"/std:c11",
// Warnings.
"/Wall",
"/wd4127", // C4127: conditional expression is constant
"/wd4464", // C4464: relative include path contains '..'
"/wd4514", // C4514: <name>: unreferenced inline function has be
"/wd4710", // C4710: function not inlined
"/wd4711", // C4711: function 'function' selected for inline expansion
"/wd4820", // C4820: <struct>: <n> bytes padding added after <name>
"/wd5045", /* C5045: Compiler will insert Spectre mitigation for memory load if
* /Qspectre switch specified */
"-Wno-pre-c11-compat", // Turn off C11 compat warnings (/Wall issues -Weverything to clang-cl)
"-Wno-declaration-after-statement", // Turn off C99 compat warnings
];
CLANG_CL_FLAGS
}
}
}

Expand Down Expand Up @@ -591,8 +614,11 @@ fn obj_path(out_dir: &Path, src: &Path) -> PathBuf {

fn configure_cc(c: &mut cc::Build, target: &Target, c_root_dir: &Path, include_dir: &Path) {
let compiler = c.get_compiler();
// FIXME: On Windows AArch64 we currently must use Clang to compile C code
let compiler = if target.os == WINDOWS && target.arch == AARCH64 && !compiler.is_like_clang() {
// FIXME: On Windows AArch64 we currently must use Clang(-cl) to compile C code
let compiler = if target.os == WINDOWS
&& target.arch == AARCH64
&& !(compiler.is_like_clang() || compiler.is_like_clang_cl())
{
let _ = c.compiler("clang");
c.get_compiler()
} else {
Expand Down