Skip to content

Conversation

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 9, 2019

For example, if you had two windows with brave://settings/privacy open

Fixes brave/brave-browser#7289

This is something I missed while implementing #3242

Submitter Checklist:

Test Plan:

See brave/brave-browser#7289

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 1.4.x - Nightly milestone Dec 9, 2019
@bsclifton bsclifton self-assigned this Dec 9, 2019
@bsclifton bsclifton changed the title Updated PrefChangeRegistrar for brave://settings/privacy to ensure P3… Add listener for brave://settings/privacy to ensure P3A enabled value is in sync Dec 9, 2019
… is in sync

For example, if you had two windows with brave://settings/privacy open

Fixes brave/brave-browser#7289

This is something I missed while implementing #3242
@bsclifton bsclifton force-pushed the bsc-p3a-enabled-sync branch from b41dd8b to d056a21 Compare December 9, 2019 21:16
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding //brave/components/p3a:buildflags in brave/browser/ui/BUILD.gn.

@bsclifton bsclifton force-pushed the bsc-p3a-enabled-sync branch from 03130fa to 46ffd80 Compare December 10, 2019 07:35
@bsclifton
Copy link
Member Author

@simonhong updated!

@simonhong
Copy link
Member

@bsclifton 👍

@bsclifton bsclifton force-pushed the bsc-p3a-enabled-sync branch from 46ffd80 to ae9bf83 Compare December 10, 2019 19:08
@bsclifton
Copy link
Member Author

Only failure on CI was audit-deps which is also happening on master; captured with brave/brave-browser#7321

@bsclifton bsclifton merged commit f6072bd into master Dec 10, 2019
@bsclifton bsclifton deleted the bsc-p3a-enabled-sync branch December 10, 2019 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P3A enabled status not updated in all windows when toggled

2 participants