Skip to content

move default_200_percent to build/chromium/resources (uplift to 1.87.x) #33845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kjozwiak merged 2 commits into from
Feb 11, 2026
Merged

move default_200_percent to build/chromium/resources (uplift to 1.87.x) #33845

kjozwiak merged 2 commits into from
Feb 11, 2026

Conversation

@brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 10, 2026 •
edited by kjozwiak
Loading

Uplift of #33224
Resolves brave/brave-browser#51998
Resolves brave/brave-browser#52729

This PR also removes 200 percent PNGs that were removed for 100 percent in #33204. Overrides for

//chrome/app/theme/default_200_percent/common/save_password_multi_device.png
//chrome/app/theme/default_200_percent/common/save_password_multi_device_dark.png
//chrome/app/theme/default_200_percent/common/save_password_one_device.png
//chrome/app/theme/default_200_percent/common/save_password_one_device_dark.png

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner February 10, 2026 19:21
@brave-builds brave-builds added this to the 1.87.x - Release milestone Feb 10, 2026
@brave-builds brave-builds self-assigned this Feb 10, 2026
@mkarolin
Removes no longer needed image overrides.
1065b08 
Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/bd2d4b7116ef9

commit bd2d4b7116ef955394188f334ddaaee26cb328c6
Author: Mohamed Amir Yosef <[email protected]>
Date:   Wed Jul 28 10:51:14 2021 +0000

    [Autofill/Passwords] Clean-up old Autofill bubble header images

    Bug: 1213685
kjozwiak
kjozwiak approved these changes Feb 11, 2026
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.87.x approved 👍

@kjozwiak kjozwiak merged commit 61fc899 into 1.87.x Feb 11, 2026
21 checks passed
@kjozwiak kjozwiak deleted the pr33224_default-200-percent_1.87.x branch February 11, 2026 03:24
@brave-builds
Copy link
Collaborator Author

brave-builds commented Feb 11, 2026

Released in v1.87.186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels

None yet

Projects

None yet

Milestone

1.87.x - Release

Development

Successfully merging this pull request may close these issues.

3 participants

@brave-builds @kjozwiak @mkarolin