Skip to content

Conversation

@DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Feb 6, 2025

Resolves brave/brave-browser#43770

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See #20264. Ignore step 1.

@DJAndries DJAndries merged commit 9114bb6 into master Feb 8, 2025
18 checks passed
@DJAndries DJAndries deleted the p3a-retention branch February 8, 2025 01:04
@github-actions github-actions bot added this to the 1.77.x - Nightly milestone Feb 8, 2025
@brave-builds
Copy link
Collaborator

Released in v1.77.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P3A feature retention reporting

3 participants