Skip to content

Conversation

@DJAndries
Copy link
Collaborator

Resolves brave/brave-browser#34003

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@DJAndries DJAndries requested a review from a team as a code owner November 1, 2023 04:06
json_log_stores_[log_type].get()->UpdateValue(std::string(histogram_name),
bucket);
auto* log_store = json_log_stores_[log_type].get();
if (log_store) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could write if(auto* log_store = json_log_stores_[log_type].get()) { ... }

Copy link
Collaborator Author

@DJAndries DJAndries Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after rebasing, the condition became a bit more complex. decided to leave it as is

@DJAndries DJAndries force-pushed the start-p3a-json-deprec branch from 474e534 to c3eb7a5 Compare November 17, 2023 01:43
@DJAndries DJAndries merged commit 0274283 into master Nov 17, 2023
@DJAndries DJAndries deleted the start-p3a-json-deprec branch November 17, 2023 04:05
@github-actions github-actions bot added this to the 1.62.x - Nightly milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add two features for deprecating JSON P3A data

2 participants