Skip to content

Misc. minor Constellation P3A updates (uplift to 1.52.x) #18410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kjozwiak merged 1 commit into from
May 12, 2023
Merged

Misc. minor Constellation P3A updates (uplift to 1.52.x) #18410

kjozwiak merged 1 commit into from
May 12, 2023

Conversation

@brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 8, 2023 •
edited by kjozwiak
Loading

Uplift of #18340
Resolves brave/brave-browser#30068

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 8, 2023 22:19
@brave-builds brave-builds self-assigned this May 8, 2023
@brave-builds brave-builds added this to the 1.52.x - Beta milestone May 8, 2023
@DJAndries DJAndries mentioned this pull request May 8, 2023
Merged
25 tasks
kjozwiak
kjozwiak approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.52.x approved 👍

@kjozwiak kjozwiak merged commit 415ad5e into 1.52.x May 12, 2023
@kjozwiak kjozwiak deleted the pr18340_star-p3a-misc-changes_1.52.x branch May 12, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels

None yet

Projects

None yet

Milestone

1.52.x - Release

Development

Successfully merging this pull request may close these issues.

2 participants

@brave-builds @kjozwiak