Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
data/update-lists.js
Outdated
| const readline = require("readline"); | ||
| const fs = require("fs"); | ||
|
|
||
| const rl = readline.createInterface({ |
There was a problem hiding this comment.
wouldn't it be easier to pass the key as a command parameter?
There was a problem hiding this comment.
make sense, done.
This reverts commit baf562a.
data/update-lists.js
Outdated
| ); | ||
|
|
||
| try { | ||
| execSync("unzip extension.zip list.txt"); |
There was a problem hiding this comment.
I'd either do this part in a temp directory or warn if there are any existing files that could get overwritten
There was a problem hiding this comment.
Updated to use a temp dir.
|
|
||
| [features] | ||
| default-panic-hook = [] |
There was a problem hiding this comment.
I don't think this does anything?
There was a problem hiding this comment.
Without it the build got red from time to time:
https://github.com/brave/adblock-rust/actions/runs/12949269594/job/36119648931#step:6:186
There was a problem hiding this comment.
One of the changes in Rust 1.84 is rust-lang/rust#132577, so this is now a lint warning (and thus an error since we've configured lint warnings as errors). I think it's resolved in newer versions of Neon, but we can leave it here as-is for now.
5 participants
The PR:
2 updates easylists*, remove file duplicates and add brave main list in the benchmarks. Also provides a script to do the next updates.
An example (from a forked repo):
