Skip to content

Fix #2713 - search unmounts unexpectedly #2726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
katarzynatobis merged 3 commits into from
Apr 20, 2023
Merged

Fix #2713 - search unmounts unexpectedly #2726

katarzynatobis merged 3 commits into from
Apr 20, 2023

Conversation

@katarzynatobis
Copy link
Contributor

@katarzynatobis katarzynatobis commented Apr 19, 2023 •
edited
Loading

closes #2713

@katarzynatobis katarzynatobis force-pushed the #2713-search-unmounts-unexpectedly branch from 1c5a262 to 21c2476 Compare April 19, 2023 15:20
@katarzynatobis katarzynatobis marked this pull request as ready for review April 19, 2023 15:51
@katarzynatobis katarzynatobis requested a review from a team as a code owner April 19, 2023 15:51
@clxandstuff
Copy link
Contributor

clxandstuff commented Apr 20, 2023

Since you removed outer div, you should add label Change: Internal Layout Marking release change containing modifications inside internal layout or dom tree

@katarzynatobis katarzynatobis added the Change: Internal Layout Marking release change containing modifications inside internal layout or dom tree label Apr 20, 2023
@katarzynatobis katarzynatobis merged commit 4c766a1 into master Apr 20, 2023
@katarzynatobis katarzynatobis deleted the #2713-search-unmounts-unexpectedly branch April 20, 2023 09:35
@clxandstuff clxandstuff mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clxandstuff clxandstuff clxandstuff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Change: Internal Layout Marking release change containing modifications inside internal layout or dom tree

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Search component's button unmounts unexpectedly

3 participants

@katarzynatobis @clxandstuff