Allow Flex component to be flex child #2725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clxandstuff
approved these changes
Apr 19, 2023
src/components/flex/Flex.stories.mdx
Outdated
| FLEX_MARGINS, | ||
| FLEX_JUSTIFY_VALUES, | ||
| FLEX_GAP_VALUES, | ||
| FLEX_FLEX_VALUES, |
Contributor
There was a problem hiding this comment.
maybe 2X_FLEX_VALUES to DRY ;)
Contributor
There was a problem hiding this comment.
imho this whole FLEX_ prefix is just redundant. We did this stuff mostly in the times where the flow was used instead of ts. The only case we need to import those consts is for iterating in docs
Contributor
Author
There was a problem hiding this comment.
I've removed that prefix
katarzynatobis
force-pushed
the
flex-add-children-props
branch
from
88d702e to
a5675b2
Compare
clxandstuff
approved these changes
Apr 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add responsive
flexprop to Flex component with values:initial,none,auto, <1, 12>.