Skip to content

Comments

pin vtk to 9.6.0 before GetCells is deprecated#751

Closed
PolarBean wants to merge 3 commits intomainfrom
fix-failing-test
Closed

pin vtk to 9.6.0 before GetCells is deprecated#751
PolarBean wants to merge 3 commits intomainfrom
fix-failing-test

Conversation

@PolarBean
Copy link
Member

tests have begun failing. I think it is due to a dependancy being updated and us relying on deprecated functions.

@PolarBean PolarBean marked this pull request as ready for review February 12, 2026 19:46
@PolarBean PolarBean requested a review from a team February 12, 2026 19:46
@PolarBean
Copy link
Member Author

This fixes the failure that was occuring on the previous commit to main .

Should I follow this up with an issue on Vedo?

@PolarBean PolarBean marked this pull request as draft February 12, 2026 19:48
@PolarBean PolarBean marked this pull request as ready for review February 12, 2026 19:52
@sonarqubecloud
Copy link

@IgorTatarnikov
Copy link
Member

IgorTatarnikov commented Feb 13, 2026

Ah, I went down a rabbit hole before seeing your second comment, didn't see that you offered to open an issue in vedo. I got carried away and opened the issue myself. See marcomusy/vedo#1292

I propose instead of pinning, we just filter the DeprecationWarnings on those specific tests. They don't fail as of now, but just throw a warning. We can add @pytest.mark.filterwarnings("ignore::DeprecationWarning") to the offending tests, until it's fixed upstream.

@IgorTatarnikov
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants