[CLOSED] "close others" extension added to default extensions directory.

[core-ai-bot]

Issue by sathyamoorthi
Sunday Jul 28, 2013 at 16:46 GMT
Originally opened as adobe/brackets#4590

---

adobe/brackets#4469

---

sathyamoorthi included the following code: https://github.com/adobe/brackets/pull/4590/commits

[core-ai-bot]

Comment by sathyamoorthi
Monday Jul 29, 2013 at 01:32 GMT

---

I got three warnings in "Travis Build" and notified as Failed. I gave proper pull request. But i don't know the reason for Failure. Can anybody help me in this to proceed further?

[core-ai-bot]

Comment by larz0
Monday Jul 29, 2013 at 03:39 GMT

---

@sathyamoorthi I've been getting those warnings as well. I'll mention it tomorrow.

[core-ai-bot]

Comment by sathyamoorthi
Monday Jul 29, 2013 at 04:36 GMT

---

@larz0 ahhh. Thank you. I am not an expert in Github. I created this PR because i got this same error in my old PR. When i got "Travis" warnings again here, i was totally blank. Thank god, you gave positive reply.

[core-ai-bot]

Comment by JeffryBooher
Monday Jul 29, 2013 at 22:16 GMT

---

@sathyamoorthi There was a change to jsHint that is causing all builds to fail. We have a fix that will go in once we have sprint 28 wrapped up and delivered.

[core-ai-bot]

Comment by sathyamoorthi
Tuesday Jul 30, 2013 at 06:09 GMT

---

@JeffryBooher small bug in this pull request. Let me update this on next commit.

[core-ai-bot]

Comment by sathyamoorthi
Wednesday Jul 31, 2013 at 07:06 GMT

---

@JeffryBooher,@TomMalbran committed new set of changes that you both mentioned. Still, i am expecting some more changes after your review. So i didn't add comments to functions that i have added in the core. Once, everything finalized we can add function headers.

[core-ai-bot]

Comment by JeffryBooher
Sunday Aug 25, 2013 at 02:23 GMT

---

@sathyamoorthi are you still working on this?

[core-ai-bot]

Comment by sathyamoorthi
Sunday Aug 25, 2013 at 02:35 GMT

---

@JeffryBooher yes. i committed changes that you have mentioned. i'm waiting for your review.

[core-ai-bot]

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:14 GMT

---

Done with review. Just a couple of minor naming nits and this is ready to merge. Good Job!

[core-ai-bot]

Comment by sathyamoorthi
Sunday Aug 25, 2013 at 04:28 GMT

---

@JeffryBooher changed those function names.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Aug 27, 2013 at 16:58 GMT

---

Can you merge master into this branch? There are quite a number of unit-test failures that I don't understand. I'm hoping that merging master into the branch fixes most of them.

[core-ai-bot]

Comment by sathyamoorthi
Saturday Aug 31, 2013 at 02:26 GMT

---

@JeffryBooher any more changes needed?

[core-ai-bot]

Comment by JeffryBooher
Saturday Aug 31, 2013 at 02:29 GMT

---

@sathyamoorthi I haven't had time the past few days to look at it since we've been closing down Sprint 30. I'll look at it over the weekend.

[core-ai-bot]

Comment by sathyamoorthi
Saturday Aug 31, 2013 at 02:41 GMT

---

@JeffryBooher sure.np.

[core-ai-bot]

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 16:55 GMT

---

The code looks great.

There are a few unit test failures that you need to fix plus you need unit tests for close others, close above, and close below.

I'd start by merging master into your branch. I think there are some failures that may be due to the fact that you're out of date with the current shell plus some others that have been fixed in master.