Feature/month addition #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* reading caption and title from several tags with several tests added minor bugfix for date conversion to MS optimization: break sidecar loop, when first sidecar is found
|
aggh that is rough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does 1 month back mean, when it's 31st of march 2020 (which was a leap year)?
Does it mean 31st of february, which doesn't exist, so 31st of february becomes 29th of february + 2 days, i.e. 2nd of march?
I think that when you subtract a month, you HAVE to end up in the previous month. And the consequence is that 31st of March 2020 minus 1 month becomes 29th of february (and even the 28th on non-leap years).
This PR alters the behavior or x months subtration in this manner. :)