Feature/location info (#9) #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Show comma-separated city, state and country in infobox and in gallery mode. All of the values that are non-empty will be shown. * methodcall to isPhoto * Unit test and bugfix for CreationDate (#8) * fixed the DiskManagerWorker test * s (#10) * Unit test and bugfix for CreationDate (#8) * fixed the DiskManagerWorker test --------- Co-authored-by: Patrik J. Braun <[email protected]> * s (#11) * Unit test and bugfix for CreationDate (#8) * fixed the DiskManagerWorker test --------- Co-authored-by: Patrik J. Braun <[email protected]> * 9ij (#12) * Unit test and bugfix for CreationDate (#8) * fixed the DiskManagerWorker test --------- Co-authored-by: Patrik J. Braun <[email protected]> --------- Co-authored-by: Patrik J. Braun <[email protected]>
|
A matter of taste perhaps. I thought with the nice searchable data, it might also be displayed. Especially in places like the USA where the state is rather important info. For example: Beverly Hills exist in 5 different states, not only the one in California :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
