-
Notifications
You must be signed in to change notification settings - Fork 340
feat(metadata-editor): Metadata API adjustments #4192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant metadataTaxonomyFetcher
participant API
Caller->>metadataTaxonomyFetcher: Call fetcher with params
metadataTaxonomyFetcher->>API: Fetch metadata options
API-->>metadataTaxonomyFetcher: Return metadataOptions (with/without new fields)
metadataTaxonomyFetcher-->>Caller: Return options with parentId, nodePath, deprecated, limit, totalResultCount
Suggested labels
Poem
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Should we also add a test to check that |
Description
Following the recent API specification updates for Options and Nodes endpoints, new API testing on dev environment has been successful. The current ML taxonomies implementation is working fine with the updated APIs, indicating that minimal changes are needed at this time.
Changes Made
Core Attribute Support
Added support for new API response fields in metadataTaxonomyFetcher:
parentId- Parent node identifier for hierarchical relationshipsnodePath- Array of ancestor node IDs representing the path from rootdeprecated- Boolean flag indicating if the option is deprecatedtotalResultCount- Total number of results availablelimit- Current result limitBackward Compatibility
Support is still in place for both legacy field names (display_name) and new names (displayName)
Handling of missing new fields - they're passed through as
undefinedif not presentNo breaking changes to existing functionality
Testing Coverage
Updated unit tests to verify new field mapping
Added test cases for backward compatibility scenarios
Verified handling of missing fields to ensure robustness
Screenshots and recordings
Screen.Recording.2025-07-16.at.20.37.06.mov
Summary by CodeRabbit
New Features
Tests