feat(metadata-sidebar): Pass isLargeFile to MetadataInstanceForm #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kajarosz
force-pushed
the
isLargeFile
branch
from
08b7d76 to
24266ac
Compare
wpiesiak
reviewed
Feb 14, 2025
tjuanitas
reviewed
Feb 14, 2025
src/elements/content-sidebar/__tests__/isFileLargerThan.test.tsx
Outdated
Show resolved
Hide resolved
| import { type BoxItem } from '../../../common/types/core'; | ||
|
|
||
| export function isFileLargerThan(file: BoxItem, breakpoint: number): boolean { | ||
| return file ? file.size > breakpoint : false; |
Contributor
There was a problem hiding this comment.
nit: file is required param so maybe you dont need the ternary?
Contributor
Author
There was a problem hiding this comment.
@tjuanitas I've adjusted typing here - file can also be null is useSidebarMetadataFetcher is still processing, so we need to take care of this scenario here.
kajarosz
force-pushed
the
isLargeFile
branch
from
cf6cb7b to
6ff1b28
Compare
wpiesiak
previously approved these changes
Feb 17, 2025
jankowiakdawid
previously approved these changes
Feb 17, 2025
kajarosz
dismissed stale reviews from jankowiakdawid and wpiesiak
via
385a560
kajarosz
force-pushed
the
isLargeFile
branch
from
6ff1b28 to
385a560
Compare
jankowiakdawid
approved these changes
Feb 18, 2025
tjuanitas
approved these changes
Feb 18, 2025
kajarosz
force-pushed
the
isLargeFile
branch
from
385a560 to
d1b4493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if file is bigger that 1MB and pass
isLargeFiletoMetadataInstanceFormso that Large File Warning Inline Notice can be displayed.