fix: An empty string nextMarker should be treated as end-of-paging.
#893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Box V2 API docs are inconsistent on this. However it is stated on the paging docs(1): > If this value is null or an empty string there are no more results to fetch. So with this change empty string next_markers will end paging. (1): https://developer.box.com/guides/api-calls/pagination/marker-based/#collections
jlawton
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Box V2 API docs are inconsistent on this. However it is stated on the paging docs(1):
So with this change an empty string next_marker will end paging.
(1): https://developer.box.com/guides/api-calls/pagination/marker-based/#collections
Issue Link 🔗
#892