feat: implement web auth flow UI and interactions#99
Conversation
gulcetahtasiz
left a comment
There was a problem hiding this comment.
Great work overall, the auth flow structure and UI look clean and well thought out
I have a couple of points:
-
Merge conflict (blocking)
There is an unresolved merge conflict in globals.css that needs to be fixed before this PR can be merged.
It looks like both branches modified the same button styles. Please make sure to keep the base button reset styles from development (instead of the commented version) to maintain UI consistency. -
UX improvement (non-blocking)
Nice work on the signup flow, especially the draft restore after email verification.
I noticed a UX issue: when filling the signup form and navigating to Terms of Service or Privacy Policy, returning back resets all form inputs. This can lead to loss of user input and may be frustrating.
Thanks for the effort
kckagancan
left a comment
There was a problem hiding this comment.
- Component and filename mismatch at AuthShowCase.tsx (func name AuthShowcase)
At SignupForm.tsx:
- sessionStorage holds password which is an issue
- There is no cleanup for setTimeout
- Password is logged which is an issue
At SelectInput.tsx:
- label and shortLabel are made mandatory which is not a good idea I think.
- key generation is little too complex
- className goes to invisible select
resolved the restore issue for Terms of Service / Privacy Policy navigation |
fixed AuthShowcase filename mismatch |
|
Addressed the review comments and synced the branch with the latest development. Updates include:
|
gulcetahtasiz
left a comment
There was a problem hiding this comment.
Tested the flow, everything is working smoothly. Great job, ready to merge
kckagancan
left a comment
There was a problem hiding this comment.
Looks good now. Merging.
Summary
This PR implements the web auth flow for NEPH.
Included
Notes