feat: add layered module structure and implement GET /profiles/me#93
Merged
mehmetcangurbuz08 merged 2 commits intoMar 21, 2026
Merged
Conversation
mehmetcangurbuz08
requested review from
AlperKartkaya,
berat-sayin and
delibas-rojhat
March 19, 2026 14:05
AlperKartkaya
requested changes
Mar 19, 2026
AlperKartkaya
left a comment
AlperKartkaya
left a comment
Contributor
There was a problem hiding this comment.
Great structure and solid database logic, but please fix these two security issues before we merge:
x-user-idSpoofing: Invalidators.js, the temporaryheaders['x-user-id']fallback allows anyone to bypass auth. Please wrap it inif (process.env.NODE_ENV === 'development').- Soft-Deleted Users: In
repository.js,findProfileBundleByUserIdforgets to check if a user is deleted. PleaseJOIN users uand addu.is_deleted = FALSEso deleted accounts can't fetch their profiles.
Looks good otherwise!
AlperKartkaya
approved these changes
Mar 19, 2026
AlperKartkaya
left a comment
AlperKartkaya
left a comment
Contributor
There was a problem hiding this comment.
No dragons spotted. Good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the initial profiles backend foundation with a layered module structure (routes, controller, service, repository, validators) and added working GET /api/profiles/me endpoint.
This establishes the base for upcoming PATCH profile endpoints while keeping response/error handling aligned with shared API conventions.
Closes #94