feat: implement guest-access news and emergency flows on android#182
Merged
Conversation
kckagancan
requested changes
Apr 1, 2026
kckagancan
left a comment
Contributor
There was a problem hiding this comment.
AppNavGraph.kt
Critical issues
-
Profile logout does not actually clear the auth session
- In the
ProfileScreenroute,onLogoutonly navigates toWelcome. - It does not call
AuthRepository.logout(). - This means the user may appear logged out in the UI while the token/session still remains active.
- In the
-
Protected routes are not guarded at the route level
- Access control is currently enforced through
canAccessRoute(...)andnavigateToDrawerRoute(...). - This only protects navigation when it goes through that helper.
- Protected screens such as
MyHelpRequests,AssignedRequest,Profile,Settings,Notifications,GatheringAreas,EditProfile, andPrivacySecuritydo not have their own auth guard inside theircomposable(...)blocks. - Because of that, guest users may still reach these screens through direct navigation, back stack behavior, or future incorrect wiring.
- Access control is currently enforced through
kckagancan
self-requested a review
April 1, 2026 23:15
Contributor
Author
|
Thanks for the review, addressed both points. Profile logout now clears auth/session before navigating to Welcome. |
kckagancan
approved these changes
Apr 1, 2026
kckagancan
left a comment
Contributor
There was a problem hiding this comment.
Looks fine now. Great work.
gulcetahtasiz
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the guest-accessible navigation flow on Android for public information pages and adds interactive emergency dialing support.
Included
• guest access to:
• Home
• News & Announcements
• Emergency Numbers
• guest drawer footer updated with:
• placeholder avatar/icon
• login/signup entry flow when tapped
• authenticated users keep access to the same pages
• authenticated drawer footer shows the initial-based avatar state
• news filtering support added for:
• All
• Preparedness
• Announcement
• Community
• emergency number rows are now interactive and open the phone dialer when tapped
Notes
• This PR focuses on navigation/accessibility behavior and placeholder/public information flows.
• Guest users are intentionally limited to public informational pages only.
• Authenticated users continue to access the same public pages with their authenticated drawer/avatar state.
• Emergency number interaction currently opens the device dialer and does not directly place a call.