-
Notifications
You must be signed in to change notification settings - Fork 3
WEB3-560: feat: Helpers for queries over multiple blocks of the same chain #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Wollac
wants to merge
32
commits into
main
Choose a base branch
from
feat/multiblock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
749a1d6
add multiblock env
Wollac 651c2a4
fix doc
Wollac 734f7bc
explain reason for allow(private_bounds)
Wollac db651c4
update CHANGELOG.md
Wollac 2a4e88b
minor improvements
Wollac 50df33e
use MultiblockEvmEnv
Wollac a6a8717
shorten log
Wollac 03587f0
fix clippy warning
Wollac 5b6844e
export history consts
Wollac a145f69
Merge branch 'main' into feat/multiblock
Wollac 018b819
add tests for all commitments
Wollac 64c678f
add len
Wollac 304dbbb
add is_empty
Wollac 108e1e4
Update crates/steel/src/multiblock.rs
Wollac 19cc995
nit
Wollac 44bb11a
improve token-stats example
Wollac d72fd51
cleanups
Wollac 6cc201f
fix license header
Wollac 281d147
add block number
Wollac 0930d42
simplify input builder
Wollac d169719
add STEEL_TEST_CANCUN_CHAIN_SPEC
Wollac dc22bcf
add STEEL_TEST_CANCUN_CHAIN_SPEC
Wollac c275041
cargo fmt
Wollac 1a882b2
sort test chain configs
Wollac 11fbe87
Merge branch 'main' into feat/multiblock
Wollac 6212fa7
fix unused imports
Wollac afe26ed
Merge branch 'main' into feat/multiblock
Wollac 0d37730
add eth aliases
Wollac a8e2a90
revert Steel.sol changes
Wollac d013121
fix clippy warnings
Wollac bb2b346
Revert "fix clippy warnings"
Wollac 8c0a86c
cleanups
Wollac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the callsite for this function in
multiblock, it was not obvious to me that this clones rather than consumingselflike many of the other methods do. I might suggest making this consumeself, and adding an explicitclonein front of the calls.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Rust naming conventions
to_is borrowed -> owned for non-Copy types, likePath::to_strorstr::to_lowercase().So the alternative would be to rename this to an
into_and combine it will an explicitclone, I'll check whether that might help readability, even though it will always be combined with a clone.