Bottlerocket Testing Cli #487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecpullen
reviewed
Jul 22, 2022
agent/test-agent-cli/examples/example_test_agent_cli/Dockerfile
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
from
045e254 to
0480944
Compare
ecpullen
reviewed
Jul 25, 2022
Contributor
ecpullen
left a comment
ecpullen
left a comment
There was a problem hiding this comment.
Some more comments. We may want to reconsider some command invocations.
Consider:
test-agent init
test-agent terminate
test-agent send-results --passed 1 or test-agent results --passed 1
test-agent get-secret my-secret or test-agent secret my-secret
test-agent error
test-agent retry-count etc
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
ecpullen
reviewed
Jul 25, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
2 times, most recently
from
29f3a32 to
95e2ca0
Compare
etungsten
reviewed
Jul 27, 2022
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
3 times, most recently
from
3be2916 to
b6312ab
Compare
ecpullen
reviewed
Jul 28, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
6 times, most recently
from
6143c20 to
18a05b5
Compare
ecpullen
reviewed
Aug 3, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
2 times, most recently
from
7e0add6 to
841fae5
Compare
ecpullen
reviewed
Aug 8, 2022
ecpullen
reviewed
Aug 8, 2022
ecpullen
reviewed
Aug 8, 2022
ecpullen
reviewed
Aug 8, 2022
ecpullen
reviewed
Aug 8, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
3 times, most recently
from
bce1ad7 to
31a23be
Compare
ecpullen
reviewed
Aug 11, 2022
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
ecpullen
reviewed
Aug 11, 2022
Contributor
ecpullen
left a comment
ecpullen
left a comment
There was a problem hiding this comment.
Mostly nits. It's getting very close.
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
7 times, most recently
from
044f016 to
02c1a62
Compare
ecpullen
reviewed
Aug 12, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
3 times, most recently
from
c9e30fa to
b3eafd2
Compare
etungsten
force-pushed
the
Bottlerocket_esting_cli
branch
from
b3eafd2 to
d63ca47
Compare
ecpullen
reviewed
Aug 15, 2022
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
from
d63ca47 to
52e5a5a
Compare
Closed
ecpullen
reviewed
Aug 15, 2022
Contributor
ecpullen
left a comment
ecpullen
left a comment
There was a problem hiding this comment.
Great work. 1 more small thing.
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
3 times, most recently
from
e614452 to
85f1d99
Compare
etungsten
approved these changes
Aug 16, 2022
Contributor
etungsten
left a comment
etungsten
left a comment
There was a problem hiding this comment.
Awesome! Just a last few nits.
agent/test-agent-cli/examples/example_test_agent_cli/example-test.sh
Outdated
Show resolved
Hide resolved
vyaghras
force-pushed
the
Bottlerocket_esting_cli
branch
from
85f1d99 to
7335679
Compare
stmcginnis
reviewed
Aug 17, 2022
stmcginnis
approved these changes
Aug 17, 2022
Contributor
stmcginnis
left a comment
stmcginnis
left a comment
There was a problem hiding this comment.
Looks good to me, but will leave it to @ecpullen or @etungsten to do the actual merge since they have more context on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
A CLI that can help in writing test case using Bash Script(This CLI takes care of all the interaction with Kubernetes Cluster). This CLI contains following commands
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.