[ME-4536] More Quality Improvements #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve proxy code quality by refactoring logging and debugging implementations and cleaning up legacy debug flags. Key changes include:
- Removal and replacement of raw fmt debug statements with structured logger calls.
- Refactoring of the ServerSession structure to encapsulate logger, tdsSession, and a dedicated debug flag.
- Simplification of buffer read functionality by removing the fallback options from BeginRead.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| token.go | Removed redundant debug logging calls using fmt statements in token parsing. |
| tds.go | Eliminated the border0DebugLogs field to streamline session configuration. |
| proxy.go | Refactored ServerSession to include dedicated logger/debug, updated logging usage, and shifted session-related methods to ServerSession. |
| buf.go | Simplified the BeginRead function by removing legacy options and commented code. |
| // FIXME: REMOVE | ||
| if s.border0DebugLogs { | ||
| fmt.Printf("Start ReadCommand: %s rpos=%d, rsize=%d\n", s.id, s.buf.rpos, s.buf.rsize) | ||
| // FIXME: remove |
There was a problem hiding this comment.
[nitpick] Remove leftover 'FIXME: remove' comments to ensure production code is clean and free of debugging artifacts.
Suggested change
| // FIXME: remove |
Author
There was a problem hiding this comment.
nope, until we are done with mssql dev-ing we will have FIXMEs and debug logs.
atoonk
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ME-4536] Improve Proxy Code Quality