[ME-4546] Clean-Up Fork, Add Custom B0 Proxy Support #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianosela
force-pushed
the
ME-4546_fork-it-up
branch
from
a871443 to
0ede7d8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
adrianosela
force-pushed
the
ME-4546_fork-it-up
branch
from
0ede7d8 to
3d1dc37
Compare
adrianosela
commented
May 8, 2025
| @@ -1,60 +0,0 @@ | |||
| //go:build go1.10 | |||
Author
There was a problem hiding this comment.
im removing this because we dont care about supporting go 1.10
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the fork while adding support for a custom B0 proxy along with new logging and token handling improvements. Key changes include updating type handling in read/write functions, adding new token types and helper structs (such as envChange and loginToken), and introducing debug logging controlled by the BORDER0_MSSQL_PROXY_DEBUG environment variable. The PR also removes an outdated example test file.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| types.go | Sets ti.Size and allocates ti.Buffer; legacy writeLongLenType code now commented out. |
| token.go | Adds new token definitions and returns token data (e.g. envChange, loginToken); debug logs marked with “FIXME: REMOVE” are introduced. |
| tds.go | Introduces new session fields (id, border0DebugLogs), updates packet header handling, and adds debug prints based on the new debug flag. |
| mssql.go | Adds a Spid() getter method. |
| lastinsertid_example_test.go | Removed example test code file. |
| buf.go | Adds new fields (wSpid, rSpid, serverConn) and modifies BeginRead behavior with new options. |
| session.go | Adjusts prelogin fields (e.g. preloginTHREADID) and updates version hardcoding. |
atoonk
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ME-4546] Clean-Up Fork, Add Custom B0 Proxy Support
Includes fixes for https://mysocket.atlassian.net/browse/ME-4463