[ME-4588] Signal Error To Clients #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request implements new functionality to signal errors to clients by adding a new done signal API.
- Introduces a doneConfig type and DoneOption function type with WithFinal and WithErrors helpers.
- Adds the SendDone method to send a done signal with optional error information to the client.
| for _, opt := range opts { | ||
| opt(dc) | ||
| } | ||
| if _, err := ss.tdsSession.buf.Write(writeDone(doneStruct{Status: dc.status, errors: dc.errors})); err != nil { |
There was a problem hiding this comment.
The doneStruct passed to writeDone includes the 'errors' field, but the writeDone function does not process or include error details in the written output. Consider updating writeDone to serialize and communicate error information if it is intended to be signaled to the client.
atoonk
approved these changes
May 16, 2025
Author
|
Closing due to staleness and because testing that was done did not reveal whether this is working or not (client seen behavior was the same - at least with microsoft sql server managemnt studio) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ME-4588] Signal Error To Clients