-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add display name to golang protobuf #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new optional string field named Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
device/device.proto (1)
70-70: Field addition is wire-compatible; add comment to avoid confusion with existingname.Tag 17 is unused, so adding
display_nameis fully backward-compatible.
Because the message now has bothnameanddisplay_name, downstream consumers may be uncertain which to surface in UIs or logs. A brief inline comment such as// human-readable label for dashboardswould remove ambiguity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
device/device.pb.gois excluded by!**/*.pb.gogen/kotlin/border0/device/v1/ServiceKt.ktis excluded by!**/gen/**gen/swift/device.pb.swiftis excluded by!**/gen/**
📒 Files selected for processing (1)
device/device.proto(1 hunks)
🔇 Additional comments (1)
device/device.proto (1)
70-70: If presence tracking is required, declare the field asoptional string.The PR description calls this an “optional string”, but the field is declared as plain
string.
In proto3 scalars are nullable but lack presence checks (has_display_name). If Go code needs that signal, mark it:optional string display_name = 17;(protoc ≥ 3.12) or wrap with
google.protobuf.StringValue.
Summary by CodeRabbit