-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ME-4678): add group to auth results #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Connector
participant Common
Client->>Connector: Request authorization
Connector->>Common: Reference Group definitions
Connector-->>Client: AuthorizeResponse (includes groups: [Group, ...])
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates protocol buffer definitions and generated code across multiple language targets to add support for groups in authentication responses. Key changes include:
- Introducing a new Group message in the proto files and generating corresponding types in Swift, Go, and Kotlin.
- Removing the @unchecked attribute from several Swift message types to improve type safety.
- Updating decoding, traversal, and DSL implementations to include the new groups field in auth responses.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gen/swift/messages.pb.swift | Adds a new Border0_Common_V1_Group struct with SwiftProtobuf.Message conformance. |
| gen/swift/device.pb.swift | Removes the @unchecked attribute from AuthChallenge-related messages. |
| gen/swift/connector.pb.swift | Adds the groups field in AuthorizeResponse and updates decoding/traversal accordingly. |
| gen/kotlin/border0/v1/AuthorizeResponseKt.kt | Introduces DSL support for the new groups field in auth responses in Kotlin. |
| gen/kotlin/border0/common/v1/GroupKt.kt | Implements a new Group DSL builder in Kotlin. |
| connector/connector.proto | Adds a new repeated field for Group in the AuthorizeResponse message. |
| connector/connector.pb.go | Adds support for the new groups field in the generated Go code for AuthorizeResponse. |
| common/messages.proto | Introduces a new Group message with uuid, name, and type fields. |
| common/messages.pb.go | Adds generated Go code for the new Group message. |
Comments suppressed due to low confidence (1)
common/messages.proto:127
- Consider adding a documentation comment for the new Group message to explain its purpose and usage.
message Group {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
common/messages.proto (1)
126-131: NewGroupmessage defined
TheGroupmessage withuuid,name, andtypefields is correctly declared under proto3. Consider adding a leading doc comment above the message to describe its semantics or enumerate valid values for thetypefield.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (7)
common/messages.pb.gois excluded by!**/*.pb.goconnector/connector.pb.gois excluded by!**/*.pb.gogen/kotlin/border0/common/v1/GroupKt.ktis excluded by!**/gen/**gen/kotlin/border0/v1/AuthorizeResponseKt.ktis excluded by!**/gen/**gen/swift/connector.pb.swiftis excluded by!**/gen/**gen/swift/device.pb.swiftis excluded by!**/gen/**gen/swift/messages.pb.swiftis excluded by!**/gen/**
📒 Files selected for processing (2)
common/messages.proto(1 hunks)connector/connector.proto(1 hunks)
🔇 Additional comments (1)
connector/connector.proto (1)
224-224: Addedgroupsfield toAuthorizeResponse
The repeatedGroupfield integrates correctly with the common protobuf definitions. In proto3, adding a new field is backward-compatible—older clients will ignore unknown fields. Make sure to regenerate all affected client/server stubs so they include this new field.
Summary by CodeRabbit