Skip to content

feat(ME-3477): add private network flag and messages #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btoonk merged 5 commits into from
Oct 3, 2024
Merged

feat(ME-3477): add private network flag and messages #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2ce65b4
feat(ME-3477): add private network flag and messages
btoonk Sep 24, 2024
3ac5887
move common messages to a dedicated package
btoonk Oct 2, 2024
95344fb
fix typo
btoonk Oct 2, 2024
6ec39dd
more typos
btoonk Oct 2, 2024
96b3c09
update comments
btoonk Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ PROTOC_GEN_GO_VERSION:=v1.34.2
PROTOC_GEN_GO_GRPC_VERSION:=v1.5.1

# add any components here after their directory has been created with .proto files
COMPONENTS:=connector device
COMPONENTS:=common connector device
Copy link
Contributor

@adrianosela adrianosela Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need common here since its being mounted as a separate volume below.

Copy link
Contributor Author

@btoonk btoonk Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we still need to built it to get the go code.


all: docker-run

docker-run: docker-build
$(foreach component, $(COMPONENTS), docker run -v $(PWD)/$(component):/app/proto $(NAME)-builder;)
$(foreach component, $(COMPONENTS), docker run -v $(PWD)/common:/app/shared/common -v $(PWD)/$(component):/app/proto $(NAME)-builder;)

docker-build:
docker build --build-arg PROTOC_GEN_GO_VERSION=$(PROTOC_GEN_GO_VERSION) --build-arg PROTOC_GEN_GO_GRPC_VERSION=$(PROTOC_GEN_GO_GRPC_VERSION) -t $(NAME)-builder .
Loading