snagflash: ums: switch from shutil.copy to shutil.copyfile#82
Closed
Taumille wants to merge 1 commit intobootlin:mainfrom
Closed
snagflash: ums: switch from shutil.copy to shutil.copyfile#82Taumille wants to merge 1 commit intobootlin:mainfrom
Taumille wants to merge 1 commit intobootlin:mainfrom
Conversation
shutil.copy attempts to preserve file permissions after the copy operation. When the destination is a device node, this triggers a PermissionError because chmod operations on device nodes typically require root privileges, even if the user has write access to the device. Switching to shutil.copyfile ensures only the data is copied to the destination, avoiding unnecessary privileged operations. Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
Collaborator
|
Hi, you shouldn't be using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shutil.copy attempts to preserve file permissions after the copy operation.
When the destination is a device node, this triggers a PermissionError because chmod operations on device nodes typically require root privileges, even if the user has write access to the device.
Switching to shutil.copyfile ensures only the data is copied to the destination, avoiding unnecessary privileged operations.