-
Notifications
You must be signed in to change notification settings - Fork 4
[Feat] inProgress에 따라 스터디 채널 탭 설정 #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
충돌 해결하고 오겠심 |
Member
|
검색 기능도.. 언젠가!! |
ShipFriend0516
approved these changes
Dec 3, 2024
Member
ShipFriend0516
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
blu3fishez
requested changes
Dec 3, 2024
Collaborator
blu3fishez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member
Author
|
@blu3piece 헉 다 false/true로 했는데 확인해보겠습니당 |
blu3fishez
approved these changes
Dec 3, 2024
Collaborator
제 착오였읍니다.... 머지할게욤 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Note
✅ 체크리스트
🧩 작업 내용
📝 작업 상세 내역
inProgress 상태에 따라 요청
#315
세부 내용은 여기에 있습니다. 위 상태에서 탭에 실제 inProgress가 반영된 결과가 나옵니다.
@백엔드추후 해당 부분 페이지네이션이 필수적일거 같습니다. 지금은 규모가 작아서 세션 생성 수가 작겠지만, 세션이 많을 때 한번에 받아오면 안될거 같아요! 일단 나중에 구현하는거로 하겠습니다.NotFound 컴포넌트 줄바꿈 지원
정우님이 만드신 notFound 컴포넌트가 중앙 정렬이 안되길래 보니까 리스트 페이지 자체에 그리드가 되어있어서 리스트가 없을 때는 그리드 안쓰도록 해서 중앙 정렬했습니다. 또 텍스트 자체 줄바꿈이 되면 깔끔할 거 같아 줄바꿈되도록 수정했습니다! + 중앙 정렬하고 돋보기 이미지와 비슷한 색상으로 맞췄습니다.
💬 다음 작업 또는 논의 사항