-
Notifications
You must be signed in to change notification settings - Fork 4
[Refactor] WebSocket 이벤트명 변경 #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ShipFriend0516
merged 19 commits into
boostcampwm-2024:dev
from
ShipFriend0516:refactor/websocket-api
Nov 26, 2024
Merged
[Refactor] WebSocket 이벤트명 변경 #228
ShipFriend0516
merged 19 commits into
boostcampwm-2024:dev
from
ShipFriend0516:refactor/websocket-api
Nov 26, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 분리하면서 아예 공식 모듈로 승격 - 스터디 세션, 시그널링 서버 핸들러보다 더 상위의 기초적인 서버 설정과 서버 인스턴스를 맡는 전역 게이트웨이
- 길어지는 로직을 아예 파일로 분리했음 - 현재로써는 로직의 수가 많지 않기에 가독성 측면에서 분리가 좋다고 판단했습니다.
- `backend/src/room/services/room-create.service.ts` 해당 파일에서 새롭게 `redisClient` 를 받아와서 새로운 roomId 값을 생성하도록 개선
- 이제 redis-stack을 사용
…erate-session-id [Fix] 세션 생성 오류 수정, 도커 컴포즈 설정파일 업데이트, 그 외 오류 수정
[Deploy] 5주차 스프린트 배포 - 1
- 설정 파일이 존재하지않으므로 설정하지 않도록 변경 - .gitignore 에 맞게 컨테이너 폴더 이름 변경
…t-component-props [Fix] Select 컴포넌트 Props 오류 해결
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
웹소켓 이벤트명 변경
✅ 체크리스트
🧩 작업 내용
📝 작업 상세 내역
이벤트명 변경
형식으로 분리, constants 폴더에 저장
🐥 리뷰 받고 싶은 포인트(선택)