Cursor Preview, 프로필 수정 컴포넌트 구현 #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djk01281
commented
Nov 25, 2024
| clientId={clientId} | ||
| onColorChange={setColor} | ||
| onClientIdChange={setClientId} | ||
| onSave={() => {}} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔖 연관된 이슈
📂 작업 내용
<Sidebar />컴포넌트 스타일 수정 (height를 맞추기 위해)📑 참고 자료 & 스크린샷 (선택)
cursor-preview.mp4
📢 리뷰 요구사항 (선택)
onSave()함수가 비어있는데, 아직<Popover />컴포넌트의 open/closed 상태를 컨트롤하는 기능이 없어서 나중에 만들어준 후에 여기서 닫아주어야 합니다!