-
Notifications
You must be signed in to change notification settings - Fork 2
[FEAT/#50] WaitingRoom 화면을 구현합니다. #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
마이크 이미지 추가 및 이미지 변경 기능 추가
Co-Authored-By: YeongHoon Song <[email protected]>
- UIControl을 상속받는 객체 또한 controlPublihser를 통해서 UIControl.Event에 대한 모든 퍼블리셔를 만들 수 있습니다. - UIButton을 상속받는 모든 객체는 tapPublisher를 확장하여 사용할 수 있습니다. Co-Authored-By: YeongHoon Song <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Co-Authored-By: Kiyoung <[email protected]>
Kiyoung-Kim-57
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여러모로 많이 배워갑니다~~
...oomFeature/PhotoRoomFeature/Source/ViewController/ParticipantsCollectionViewController.swift
Show resolved
Hide resolved
.../WaitingRoomFeature/WaitingRoomFeature/Source/ViewController/WaitingRoomViewController.swift
Outdated
Show resolved
Hide resolved
PhotoGether/PresentationLayer/DesignSystem/DesignSystem/Source/PTGPaddingLabel.swift
Show resolved
Hide resolved
PhotoGether/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/NickNameLabel.swift
Outdated
Show resolved
Hide resolved
hsw1920
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니당! 일부 수정요청과 의도를 알고 싶은 부분에 대해서 코멘트 남겼습니다.
PhotoGether/PresentationLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/NickNameLabel.swift
Outdated
Show resolved
Hide resolved
...tionLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/ParticipantsCollectionViewCell.swift
Show resolved
Hide resolved
...tionLayer/PhotoRoomFeature/PhotoRoomFeature/Source/View/ParticipantsCollectionViewCell.swift
Show resolved
Hide resolved
...ationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/ViewModel/WaitingRoomViewModel.swift
Show resolved
Hide resolved
...ationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/ViewModel/WaitingRoomViewModel.swift
Show resolved
Hide resolved
...er/PresentationLayer/WaitingRoomFeature/WaitingRoomFeature/Source/View/WaitingRoomView.swift
Outdated
Show resolved
Hide resolved
0Hooni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
몇가지 궁금한 점들을 적어놨는데 나중에 코멘트 한번만 부탁드립니다 🫡
수고 많으셨습니다!
🤔 배경
이번 주 데모에서 화면을 사용하기 위해 빠르게 구현했습니다.
📃 작업 내역
✅ 리뷰 노트
기존에 작성된 뷰모델 코드들과 컨벤션을 맞추기 위해 Input, Output 패턴을 적용하고, 단방향 플로우와 가독성을 신경썼습니다.
사용하는 곳에선 아래와 같이 바인딩하여 사용할 수 있습니다.
🎨 스크린샷
🚀 테스트 방법
WaitingRoomFeatureDemo 를 실행하면 확인하실 수 있습니다!
드디어 테스트를..