[FEAT/#33] SharePhoto 화면전환 시 필요한 Entity를 구성하였습니다. #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- didSet에서 frameView 생성이 안되는 문제를 해결
- EditPhotoRoomFeature에서 SharePhotoRoomFeature로 화면전환될 때 필요한 의존성을 구현하였습니다. - 현재는 image를 Data 타입으로 담아 보내며, 필요한 의존성이 추가될 수 있습니다.
- SharePhotoViewModel은 SharePhotoViewController에 필요한 모델을 가집니다. - 현재 imageData의 경우 리액티브가 필요 없으므로 viewModel에서 참조하여 자신의 PhotoImageView에 넣어줍니다.
FrameImageGenerator로부터 이미지를 생성하고, 해당 이미지를 Data 타입으로 변환하여 SharePhotoComponent에 담아 의존성을 주입하는 과정을 표현합니다.
Closed
2 tasks
Kiyoung-Kim-57
approved these changes
Nov 14, 2024
...ether/PresentationLayer/SharePhotoFeature/SharePhotoFeature/Source/SharePhotoViewModel.swift
Show resolved
Hide resolved
youn9k
reviewed
Nov 14, 2024
...er/DomainLayer/PhotoGetherDomain/PhotoGetherDomainInterface/Entity/SharePhotoComponent.swift
Outdated
Show resolved
Hide resolved
...er/DomainLayer/PhotoGetherDomain/PhotoGetherDomainInterface/Entity/SharePhotoComponent.swift
Outdated
Show resolved
Hide resolved
.../PresentationLayer/SharePhotoFeature/SharePhotoFeature/Source/SharePhotoViewController.swift
Show resolved
Hide resolved
PhotoGether/PresentationLayer/SharePhotoFeature/SharePhotoFeatureDemo/App/SceneDelegate.swift
Show resolved
Hide resolved
- Data 타입을 유추하기 쉽도록 프로퍼티명을 변경하였습니다.
- A-Z 순서로 변경
- DataLayer와 DomainLayer가 소통하는 Entity와 Presentation과 Domain이 소통하기위한 Component를 분리하기 위한 디렉터리 네이밍을 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
EditPhotoRoomFeature에서SharePhotoRoomFeature로 화면전환 시 담아 보낼 데이터 구조가 필요했습니다.ImageData하나는 확정이며 추가될 수 있기 때문에SharePhotoComponent로 모아서 전달할 수 있도록DomainInterface에Entity를 두었습니다.FrameImageGenerator의frameView인스턴스가 존재하지 않는 문제가 있었습니다.📃 작업 내역
SharePhotoComponent구현SharePhotoViewModel의imageData를SharePhotoViewController가 참조하여 자신의photoView에 표현하는 기능 구현FrameImageGenerator버그 픽스✅ 리뷰 노트
FrameImageGenerator버그 픽스의 경우 아래 트러블 슈팅을 작성하였습니다.🎨 스크린샷
🚀 테스트 방법
SharePhotoFeatureDemo를 실행해주세요.