[FEAT/#27] SharePhotoView UI를 구현합니다. #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 내부 공유, 저장버튼의 tapPublisher는 ViewController가 알아야 하므로 열어두었습니다.
- 현재 ImageData가 주입되는 경우가 아니기 때문에 간단하게 ShareSheet를 띄우는 것을 확인하였습니다. - 당장은 이벤트 처리가 단순하여 ViewModel을 두지 않았습니다. - 추후 ViewModel이 필요하게 될 때 Input-Output transform 패턴을 고려할 예정입니다.
Closed
3 tasks
0Hooni
approved these changes
Nov 13, 2024
Comment on lines
+88
to
+89
| private func saveImage() { | ||
|
|
Collaborator
There was a problem hiding this comment.
아직 사용하지 않는 코드로 보이는데 빼고 TODO만 남겨도 좋을것 같습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 배경
편집이 완료된 이미지를 확인하고 해당 이미지를 저장하고, 공유할 수 있는 UI가 필요했습니다.
📃 작업 내역
✅ 리뷰 노트
무지성 Input-Output transform을 했다가 너무 쓸모가 없어서 일단 ViewController만 두었습니다.
추후 ViewModel이 필요해지고, 편집화면의 Image가 넘어오는 등의 로직이 구체화되면 고민해볼 예정입니다.
앨범 저장시 권한설정에 대한 로직을 어디서 담당하는게 좋을까요?
🎨 스크린샷
Nov-13-2024.22-51-28.mp4
🚀 테스트 방법
close #27 #31