Do not try to display discarded products/variants.#23
Open
oneiros wants to merge 1 commit intoboomerdigital:masterfrom
Open
Do not try to display discarded products/variants.#23oneiros wants to merge 1 commit intoboomerdigital:masterfrom
oneiros wants to merge 1 commit intoboomerdigital:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks for the wonderful plugin. We have been evaluating it and liked it a lot.
But we found one issue: When we delete a product in the admin backend that is still stored in a wishlist, there is an exception when trying to display that wishlist.
The reason is, that the product is not actually destroyed, but there is a
deleted_attimestamp set. And there is a default scope for bothSpree::ProductandSpree::Variantthat only queries records wheredeleted_atisNULL. That is why the variant stored in the wishlist can no longer be accessed.The changes in this PR fix the issue for us. Of course, if you prefer another way to fix it, that is totally fine as well.
Thanks again and keep up the good work!