Skip to content

feat: Add tests to proof configuration syntax usability#60

Closed
DevTKSS wants to merge 2 commits intobolorundurowb:masterfrom
DevTKSS:feat-add-tests-for-loading-env-variables-for-oidc-with-configuration-syntax
Closed

feat: Add tests to proof configuration syntax usability#60
DevTKSS wants to merge 2 commits intobolorundurowb:masterfrom
DevTKSS:feat-add-tests-for-loading-env-variables-for-oidc-with-configuration-syntax

Conversation

@DevTKSS
Copy link

@DevTKSS DevTKSS commented Jun 15, 2025

Using the .Read() Method with configuration colone syntax passes the test, but using Load() does not, because Windows EnvironmentVariables are not allowing colone usage.

Please evaluate, to add a extension method for IConfigurationBuilder to pass in the appropriate key value pairs

Reading with configuration colone syntax passes the test, but using Load() does not, because Windows EnvironmentVariables are not allowing colone usage.
Please evaluate, to add a extension method for IConfigurationBuilder to pass in the appropriate key value pairs
@DevTKSS
Copy link
Author

DevTKSS commented Jun 15, 2025

if an appropriate ConfigurationBuilder Extension Method would be added, this could fix #59 and enhance Dotenv.net usablility greatly! Would like to use it in my Uno Platform Solution and add a CommunityTutorial to their docs so others would also be able to get Dotenv.net as option to User Secrets ❤️

@bolorundurowb
Copy link
Owner

@DevTKSS I merged some changes to the master branch, can you rebase. And I am looking into #59

@DevTKSS
Copy link
Author

DevTKSS commented Jun 16, 2025

@bolorundurowb I synced the main branch but it seems to have conflicts. As I was trying to see what that might have caused, I did see, you did update the FluentAssertions Versions to >8.0 😟 sorry, but I am absolutly not willing to pay for this, as that requires a per developer license AND is even then required, when you are a non profit company.
https://xceed.com/products/unit-testing/fluent-assertions/

I did just see a video about that shit move done on youtube as I readed on LinkedIn MVPs post a list for alternatives like Shouldly or AwesomeAssetions. They are providing a Fork of the Repo and cherrypicking and proceeding with having a community version by using the Apache versions of FluentAssertions <v8

But If you are willing to pay this and by using the version, have every eventual future Contributor pay for contributing indirectly... lets go... I am not...
Let me know if we migth can find a alternative way to solve that conflict, otherwise it seems like I will have to remove my fork of dotenv.net just because of this, what I would absolutly not prefer as I really appreciate what its providing. Please have a look on this. Thanks!

@DevTKSS
Copy link
Author

DevTKSS commented Jun 16, 2025

and looking at the conflicts here that it mentions wanted to resolved, that is exactly the test which is not passing because of the problem that Load() does not work as expected...

@bolorundurowb
Copy link
Owner

bolorundurowb commented Jun 16, 2025

@DevTKSS after the upgrade I saw the new license notice and I have transitioned to Shouldly which is still FOSS. I think the conflict is related to the simpler folder structure. Tests are now in the src dir as well

@DevTKSS
Copy link
Author

DevTKSS commented Jun 16, 2025

@bolorundurowb that test was already failing before you added your commits, so if your CI/CD is taught to fail if not all tests are passing, that will be the reason. That failing test was what I wanted to say with:

but using Load() does not, because Windows EnvironmentVariables are not allowing colone usage.

@DevTKSS
Copy link
Author

DevTKSS commented Jun 25, 2025

@bolorundurowb do you see, whats the problem that causes now with outcommented test the github message "This branch has conflicts that must be resolved" but right below that "Changes can be cleanly merged"? the button "Resolve Conflicts" is disabled if there are issues...

@bolorundurowb
Copy link
Owner

@DevTKSS the "resolve Conflicts" button is probably disabled because the conflicts cannot be resolved via the GitHub UI. The files you modified have been relocated which is my guess. But I migrated your tests to the file in #64.
I'll close this PR but feel free to reopen it if there is something else you want addresses by it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants