FIX: Allow escaping of backslash#58
Closed
VijoPlays wants to merge 3 commits intobolorundurowb:masterfrom
Closed
Conversation
Owner
|
Hi @VijoPlays I had some time recently and reworked the Reader class and included the changes you propose here. Take a look #62 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current version there's a bug, where if your environment variable (surrounded by double quotes) ends with a backslash, there's no way to escape it (apart from switch to single quotes, but then you can't have multi-line envs anymore).
F.ex.:
This will cause Env1 to be: Env1="..."Env2="..."
This PR addresses said issue by allowing the escaping of the backslash.
To fix it, one would need to adjust Env1 to be "...\"
THIS CAN BREAK EXISTING ENVS! (Best to put this into the release notes)